Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove singularity tools and update haiku version #147

Merged
merged 4 commits into from
Apr 28, 2023

Conversation

limbryan
Copy link
Collaborator

@limbryan limbryan commented Mar 30, 2023

Related issues: #146

This PR :

  • removes singularity tools and related documentation to remove the need to maintain a redundancy. singularity can still be used but can just be installed with pip (via pypi) or with the requirements.txt file directly.
  • updates haiku version to stop jax warnings for tree_utils.

Checks

  • a clear description of the PR has been added
  • sufficient tests have been written (N/A)
  • relevant section added to the documentation
  • example notebook added to the repo (N/A)
  • clean docstrings and comments have been written (N/A)
  • if any issue/observation has been discovered, a new issue has been opened

@limbryan limbryan changed the base branch from main to develop March 30, 2023 11:54
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Merging #147 (12124eb) into develop (6fa19e7) will increase coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop     #147      +/-   ##
===========================================
+ Coverage    92.28%   92.29%   +0.01%     
===========================================
  Files          116      116              
  Lines         6763     6772       +9     
===========================================
+ Hits          6241     6250       +9     
  Misses         522      522              

see 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@felixchalumeau felixchalumeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving one question. Ok with the rest 👍

- method: pip
path: .
- requirements: requirements.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this update?

Copy link
Member

@Lookatator Lookatator Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! The method: pip path: . actually overrides all the dependencies and put them to the lastest version (not respecting the requirements.txt).

So by putting pip install -r requirements.txt after, we enfore and respect all the dependencies to be like in the requirements.txt file.

@limbryan limbryan merged commit 26c010e into develop Apr 28, 2023
@limbryan limbryan deleted the chore/rm_singularity branch May 12, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants