-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove singularity tools and update haiku version #147
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #147 +/- ##
===========================================
+ Coverage 92.28% 92.29% +0.01%
===========================================
Files 116 116
Lines 6763 6772 +9
===========================================
+ Hits 6241 6250 +9
Misses 522 522 see 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving one question. Ok with the rest 👍
- method: pip | ||
path: . | ||
- requirements: requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for this update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! The method: pip path: .
actually overrides all the dependencies and put them to the lastest version (not respecting the requirements.txt).
So by putting pip install -r requirements.txt
after, we enfore and respect all the dependencies to be like in the requirements.txt
file.
Related issues: #146
This PR :
Checks