Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: maintain search container position when scrolling or closing drawer (fixes #68) #69

Merged
merged 4 commits into from
Apr 3, 2023
Merged

Fix: maintain search container position when scrolling or closing drawer (fixes #68) #69

merged 4 commits into from
Apr 3, 2023

Conversation

kirsty-hames
Copy link
Contributor

  • sticky fix search container to maintain position when scrolling.
  • top position is no longer required with sticky, css top removed from search and item containers.

Fixes #68

I tested the latest changes across Chrome, FF and Safari on Mac. iPhone and Android tablet. It would be good if someone can just give this a look on windows please.

@kirsty-hames
search container sticky fixed position
dc44120 
- maintain fixed position when scrolling.
- top position is no longer required with sticky.
@kirsty-hames
remove glossary-items-container css top position
e8d0c5e 
This is no longer required now that search container is sticky fixed position.
@kirsty-hames kirsty-hames self-assigned this Mar 23, 2023
@kirsty-hames
Copy link
Contributor Author

Thanks @oliverfoster. No issues testing on the same spec as above.

We could do with replacing the .glossary__textbox-container margin with padding though to prevent this shifting up when scrolled (see screenshots). I'll need to update this in Vanilla.

margin
When scrolled:
margin_on_scroll

kirsty-hames added a commit to adaptlearning/adapt-contrib-vanilla that referenced this pull request Mar 23, 2023
@kirsty-hames
replace glossary textbox margin with padding
526d42b 
- margin causes the .glossary__textbox-container to shift up when scrolled 
- part of Glossary PR adaptlearning/adapt-contrib-glossary#69
@kirsty-hames
search icon and button position amends
a127bf9 
Increased to @item-padding * 2 to accommodate padding on both container and input
@kirsty-hames kirsty-hames mentioned this pull request Mar 23, 2023
Merged
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster reopened this Apr 3, 2023
@oliverfoster oliverfoster merged commit f8e202f into master Apr 3, 2023
@oliverfoster oliverfoster deleted the issue/68 branch April 3, 2023 08:00
github-actions bot pushed a commit that referenced this pull request Apr 3, 2023
@semantic-release-bot
Chore(release): 4.2.2 [skip ci]
3b3881b 
## [4.2.2](v4.2.1...v4.2.2) (2023-04-03)

### Fix

* Maintain search container position when scrolling or closing drawer (fixes #68) (#69) ([f8e202f](f8e202f)), closes [#68](#68) [#69](#69)
@oliverfoster oliverfoster mentioned this pull request Apr 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search input display glitch when closing drawer on iPhone
3 participants
@kirsty-hames @oliverfoster @cahirodoherty-learningpool