Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/3186 General bugs and enhancements #120

Merged
merged 5 commits into from Jul 8, 2021
Merged

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Jul 1, 2021

fixes adaptlearning/adapt_framework#3186
fixes adaptlearning/adapt_framework#2623

Changed

  • Logging prints a full map of the trickle state of the course/page, indented to show structure (only when in debug logging state ?loglevel=debug + verbose in chrome debugger)
  • Locking is now _isAvailable aware
  • Locking is now also applied when a model is added or removed or its _isAvailable is changed
  • Fixed some linting issues
  • When an article has trickle enabled but _onChildren: false and the block has no config, the block now no longer inherits the article config
  • Added _showEndOfPage to example.json and readme
  • When article _requireCompletionOf === Infinity do not consider the article complete as more blocks will be added (branching support)

@oliverfoster oliverfoster self-assigned this Jul 1, 2021
@oliverfoster oliverfoster added this to New in adapt_framework: The TODO Board via automation Jul 1, 2021
@oliverfoster oliverfoster moved this from New to Needs reviewing in adapt_framework: The TODO Board Jul 1, 2021
js/models.js Outdated Show resolved Hide resolved
Copy link
Contributor

@tomgreenfield tomgreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@jayseventwo
Copy link

Comment as requested from Oliver: https://community.adaptlearning.org/mod/forum/discuss.php?d=4056

Original:
I upgraded the framework etc. earlier today (08/07/2021), and now trickle seems not to work on some elements, but does on others? Not working after Accordions are what made me realise something was up.

When an Accordion has been viewed, the trickle does not automatically scroll and display the next component (I'm not using a trickle button).

I have to exit out of the page and then go back in to see the next component.

Other components are also playing up with Trickle, but Accordion was the standout.

Update:
This latest update seems to have fixed this issue. Thanks!

@tomgreenfield tomgreenfield merged commit fcfb6cc into master Jul 8, 2021
adapt_framework: The TODO Board automation moved this from Needs reviewing to Pre-release / extended review Jul 8, 2021
@tomgreenfield tomgreenfield deleted the issue/3186 branch July 8, 2021 08:18
@oliverfoster oliverfoster moved this from Pre-release / extended review to Needs releasing in adapt_framework: The TODO Board Jul 8, 2021
@oliverfoster oliverfoster removed this from Needs releasing in adapt_framework: The TODO Board Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants