Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item copy can result in broken courseassets in other items #2347

Closed
dancgray opened this issue May 24, 2019 · 1 comment
Closed

Item copy can result in broken courseassets in other items #2347

dancgray opened this issue May 24, 2019 · 1 comment
Assignees
Labels
S: awaiting-review Completed issues waiting on reviews T: bug
Milestone

Comments

@dancgray
Copy link
Member

Expected Behaviour

Copying an item with pre-populated assets and replacing the assets in the copied item should not affect the original item's assets.

Actual Behaviour

On removal of the asset in the copied item the original items asset is removed.

Steps to Reproduce

  1. add an accordion and create an item selecting a graphic
  2. copy that item and remove the asset in the copied item
  3. original item's asset courseasset record is removed

Versions

  • Authoring Tool Version: v0.8.1
  • Framework Version: v2.4
  • Node.js Version: v10.15.3
  • MongoDB Version: v3.6
  • Operating System: n/a
  • Browser: n/a
@dancgray
Copy link
Member Author

dancgray commented Jun 3, 2019

Also see #2348 . There are inconsistencies in the way course assets are created or deleted. There is no courseasset creation on copy/paste item and no courseasset deletion on item deletion.

@tomgreenfield @taylortom @canstudios-nicolaw do you think we should just "patch" this in scaffoldListView.js or fix in a more fundamental way?

@dancgray dancgray self-assigned this Jul 1, 2019
@dancgray dancgray added the S: in-progress Issues currently being worked on - leave these be! label Jul 1, 2019
@dancgray dancgray added S: awaiting-review Completed issues waiting on reviews and removed S: in-progress Issues currently being worked on - leave these be! labels Oct 14, 2019
tomgreenfield added a commit that referenced this issue Oct 18, 2019
Add courseasset check on clone item, fixes #2347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: awaiting-review Completed issues waiting on reviews T: bug
Projects
None yet
Development

No branches or pull requests

1 participant