-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create nl-application.json #1482
base: master
Are you sure you want to change the base?
Conversation
Translation for Dutch language
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your work on the translation, @johnniezen. Please see my review comments which should fix your JSON errors.
It's worth noting that there are imminent changes to the English version due to be merged into the next release of the tool.
routes/lang/nl-application.json
Outdated
"app.submit": "Zenden", | ||
"app.newpassword": "Nieuw wachtwoord", | ||
"app.forgotpasswordblurb": "Voer het e-mail adres in wat bij uw Learning Pool Adapt account hoort, klik dan op Continue. Wij sturen een email met een link waar u makkelijk een nieww wachtwoord maakt.", | ||
"app.forgotpasswordfooter": "Indien u niet langer het e-mail adres wat bij uw Adapt account hoort gebruikt, neem dan contact op met Support voor hulp bij het herstellen van uw account.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra space after e-mail adres wat bij uw
,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also question the Learning Pool reference here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not sure if it is still valid, so I left it in. Might it be possible to change it with something like 'your organization' ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding the typos
thx to Tom Greenfield, changed all errors.
Many thanks for the PR John! Couple of things:
|
Hello Tom, if the strings are already available, please sent them, or point me were to get them and I’ll add them in the current one.
As for where they came from, the file could be a little older, like from September or October, when I wanted to make a first start.
Never really managed to get some minutes to finish.
When I noticed the ES PR recently, I compared that with mine.
If there are any mix ups, or deletions needed, just tell me so.
|
Thanks John! You'll find the latest version of the file here. |
Removed last 4 lines as no longer used in EN version.
Thanks Tom, |
@johnniezen I've just set up a quick test, and still getting differences (sorry!). Have set up this gist which will hopefully be of some help. |
Hi Tom, |
Not sure if this is still in Sync. Also looking at the Merging comment, I need to assign 2 approving reviewers. Github help notes something about using a q, but does not specify how the syntax should be. |
Translation for Dutch language
I have some errors in the file on lines 111~123, 136, 138, 317 and 318. Not sure and able how to fix.