Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert y/n into boolean when passed as cli argument #2030

Merged
merged 2 commits into from Sep 12, 2018

Conversation

lc-thomasberger
Copy link
Member

fixes #2024

@taylortom
Copy link
Member

It might make sense to roll this out as a patch release (0.5.1) while we're still testing 0.6

@lc-thomasberger lc-thomasberger self-assigned this Aug 1, 2018
@lc-thomasberger lc-thomasberger added the S: awaiting-review Completed issues waiting on reviews label Aug 1, 2018
@lc-thomasberger
Copy link
Member Author

For testing, this are all available cli arguments that can be used during installation:

node install.js \
--useJSON N \
--install Y \
--useffmpeg N \
--useSmtp N \
--useSmtpConnectionUrl N \
--serverPort 5000 \
--serverName localhost \
--dbHost localhost \
--dbName test \
--dbPort 27017 \
--dbUser N \
--dbPass N \
--dbAuthSource N \
--dataRoot data \
--sessionSecret sess-secret \
--frameworkRepository "https://github.com/adaptlearning/adapt_framework.git" \
--authoringToolRepository "https://github.com/adaptlearning/adapt_authoring.git" \
--frameworkRevision tags/v2.2.5 \
--fromAddress " " \
--rootUrl " " \
--smtpService " " \
--smtpUsername " " \
--smtpPassword " " \
--smtpConnectionUrl " " \
--masterTenantName master \
--masterTenantDisplayName Master \
--suEmail admin \
--suPassword admin \
--suRetypePassword admin

If a parameter is missing you must provide it via prompt input.

@taylortom taylortom changed the base branch from develop to release/0.5.1 August 9, 2018 10:04
@taylortom taylortom changed the base branch from release/0.5.1 to develop August 31, 2018 09:14
@taylortom taylortom changed the base branch from develop to release/0.5.1 August 31, 2018 09:39
Copy link
Contributor

@tomgreenfield tomgreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️

@taylortom taylortom changed the base branch from release/0.5.1 to develop September 4, 2018 08:04
@taylortom taylortom changed the base branch from develop to release/0.5.1 September 12, 2018 09:22
@taylortom taylortom merged commit 77879dd into release/0.5.1 Sep 12, 2018
@taylortom taylortom deleted the issue/2024 branch September 12, 2018 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: awaiting-review Completed issues waiting on reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants