Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LocalAuth.prototype.resetPassword response #2076

Merged
merged 4 commits into from Oct 8, 2018
Merged

Fix LocalAuth.prototype.resetPassword response #2076

merged 4 commits into from Oct 8, 2018

Conversation

taylortom
Copy link
Member

Fixes #2075.

@taylortom taylortom added this to the 0.5.1 milestone Sep 12, 2018
@taylortom taylortom changed the base branch from master to release/0.5.1 September 12, 2018 18:46
@taylortom taylortom changed the title Fix LocalAuth.prototype.resetPassword response Fix LocalAuth.prototype.resetPassword response Sep 17, 2018
@tomgreenfield
Copy link
Contributor

After entering the new password on the page from the link in the email, clicking the 'Change password' button does nothing for me.

@lc-thomasberger
Copy link
Member

response.success is undefined

https://github.com/adaptlearning/adapt_authoring/blob/develop/frontend/src/modules/user/views/resetPasswordView.js#L64

@taylortom taylortom self-assigned this Sep 24, 2018
@taylortom taylortom added the S: in-progress Issues currently being worked on - leave these be! label Sep 24, 2018
@taylortom taylortom removed the S: in-progress Issues currently being worked on - leave these be! label Sep 25, 2018
@taylortom
Copy link
Member Author

@tomgreenfield @lc-thomasberger have removed that if block

@taylortom taylortom merged commit 87dd116 into release/0.5.1 Oct 8, 2018
@taylortom taylortom deleted the issue/2075 branch October 8, 2018 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomgreenfield tomgreenfield tomgreenfield approved these changes

@dancgray dancgray dancgray approved these changes

@lc-thomasberger lc-thomasberger lc-thomasberger approved these changes

Assignees

@taylortom taylortom

Labels
None yet
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taylortom @tomgreenfield @lc-thomasberger @dancgray