Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce fixed Mongoose dependency #2541

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Reintroduce fixed Mongoose dependency #2541

merged 3 commits into from
Nov 9, 2020

Conversation

tomgreenfield
Copy link
Contributor

@tomgreenfield tomgreenfield commented Oct 22, 2020

The PR reintroduces the mongoose@5.8.13 dependency, which in turn pulls down the last version of mongodb that's known to work with the domain/session code in the authoring tool. Reference: #2504.

This does surface the following warnings in recent versions of Node.js:

(node:20860) Warning: Accessing non-existent property 'count' of module exports inside circular dependency
(node:20860) Warning: Accessing non-existent property 'findOne' of module exports inside circular dependency
(node:20860) Warning: Accessing non-existent property 'remove' of module exports inside circular dependency
(node:20860) Warning: Accessing non-existent property 'updateOne' of module exports inside circular dependency

However, this seems like an adequate compromise having already done a sizeable chuck of debugging to try and ascertain why the domain goes missing in the middleware with later versions of mongodb.

This prevents the 'sticky session' problem detailed in #2540.

Tested in Node 12 & 14.

deltanetdan
deltanetdan previously approved these changes Nov 5, 2020
Copy link
Member

@taylortom taylortom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worksforme 🎉

@tomgreenfield tomgreenfield merged commit bed7169 into master Nov 9, 2020
@tomgreenfield tomgreenfield deleted the issue/2540 branch November 9, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants