Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib-narrative/-hotgraphic mobileInstruction only works with instruction #2069

Closed
simondate opened this issue May 17, 2018 · 3 comments
Closed

contrib-narrative/-hotgraphic mobileInstruction only works with instruction #2069

simondate opened this issue May 17, 2018 · 3 comments

Comments

@simondate
Copy link
Member

Subject of the issue/enhancement/features

The mobileInstruction attribute works by replacing the instruction text. But if instruction hasn't been assigned there is nothing to replace so it's never loaded in.

Steps to reproduce

  • Create a narrative or hotgraphic
  • Set a mobileInstruction but not a instruction
@simondate
Copy link
Member Author

suggested fix

Have two separate HTML attributes and use CSS media queries to hide/show the correct one. This is also probably more performant than a Jquery call.

@NayanKhedkar NayanKhedkar mentioned this issue May 24, 2018
Merged
@NayanKhedkar
Copy link
Member

PR: #2093

@moloko
Copy link
Contributor

moloko commented Jun 5, 2018

done in f99f798

@moloko moloko closed this as completed Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@moloko @simondate @NayanKhedkar