Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify router #2712

Closed
oliverfoster opened this issue Apr 1, 2020 · 0 comments · Fixed by #2713
Closed

Simplify router #2712

oliverfoster opened this issue Apr 1, 2020 · 0 comments · Fixed by #2713
Assignees
@danielghost @oliverfoster
Labels
enhancement

Comments

@oliverfoster
Copy link
Member

Subject of the enhancement

The router currently has a lot of duplicate code and some functions which contain more than one large abstraction. This can now be simplified.

Building on PR #2711

Your environment

  • 5.3.* Framework
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielghost danielghost

@oliverfoster oliverfoster

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issue/2712 Simplified router adaptlearning/adapt_framework
3 participants
@danielghost @oliverfoster @olivermartinfoster