Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkIfResetOnRevisit does not give user notification. #495

Closed
olivermartinfoster opened this issue Jan 8, 2015 · 6 comments
Closed

checkIfResetOnRevisit does not give user notification. #495

olivermartinfoster opened this issue Jan 8, 2015 · 6 comments

Comments

@olivermartinfoster
Copy link
Contributor

questionView.checkIfResetOnRevisit function

Does not give user notification on reset and returns the user to a blank and incomplete component on a page revisit as per forum comment

This needs to be fixed.

@darylhedley
Copy link
Contributor

This should be handle by plugins wanting to reset questions on revisit as this is by default set to not reset

@oliverfoster
Copy link
Member

I agree, this function should be part of a plugin. Perhaps called, adapt-contrib-resetOnRevisit ?

@taylortom
Copy link
Member

Is the suggestion then to refactor 'checkIfResetOnRevisit' into a separate plugin?

@olivermartinfoster
Copy link
Contributor Author

Only plugins should reset components and give appropriate notification. checkIfResetOnRevisit is a specific reset behaviour actioned on a page revisit. This type of reset behaviour is only one use-case for resetting and should indeed be a separate extensios. This would allow people to choose which reset behaviour they would like. The extension could listen to pageView:prerender, select all children components which have _isResetOnRevisit: true, ask the user via a prompt and proceed to reset or not based upon their feedback and using the model based behaviour. The component/question views wouldn't need its own reset behaviour except for instances of UI resetting whereby the component is reset whilst on the page. For this each component can listen to _isInteractionComplete: true>false and implement UI resetting accordingly.

@oliverfoster
Copy link
Member

#493

@oliverfoster
Copy link
Member

#498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants