removing null implementations as they will be handled by default beha… #1435

jameswickham · 2023-08-14T15:09:54Z

Motivation

Updating the class that calls the RetryStore interface to remove the null implementations of the methods: obtainExpiredMessages and obtainMessagesToRetry as they now have default implementations in the interface.

Modification

S3RetryStore

PR Checklist

been self-reviewed.
Added javadocs for most classes and all non-trivial methods
[n/a] Added supporting annotations (like @XStreamAlias / @ComponentProfile)
[n/a] Added DefaultValue annotation when there is a default value (e.g. @DefaultValue('true'))
[n/a] Added validation annotation (@NotNull...) when required and add @Valid when nested class has some validation
[n/a] Checked that @NotNull and @notblank annotations have a meaningful message when appropriate.
[n/a] Checked that new 3rd party dependencies are appropriately licensed
[n/a] Added comments explaining the "why" and the intent of the code wherever it would not be obvious for an unfamiliar reader
[n/a] Added unit tests or modified existing tests to cover new code paths
[n/a] Tested new/updated components in the UI and at runtime in an Interlok instance
[n/a] Reviewed java class members so that missing annotations are added (InputFieldDefault/ComponentProfile etc)
[n/a] Checked that javadoc generation doesn't report errors
[n/a] Checked the display of the component in the UI
[n/a] Remove any config/license annotations
[n/a] Check the gradle build file to make sure the dependencies section is more explicit "implementation/api".