-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix child process issue, and use shorter name of the open in browser … #11
Conversation
adashen
commented
Dec 8, 2017
- Use "Open in browser" as the open web page button and use tooltip to show the full url to fix issue Open web page button will be hidden by debug button in status bar #7
- Stop all the running tomcat when deactivate the extension to fix issue tomcat still running after close vscode #6
src/Tomcat/TomcatController.ts
Outdated
@@ -204,7 +214,9 @@ export class TomcatController { | |||
|
|||
// tslint:disable-next-line:no-http-string | |||
const serviceuri: string = `http://localhost:${serverPort}/${appName}`; | |||
statusBar.text = `Open http://localhost:${serverPort}/${appName}`; | |||
// tslint:disable-next-line:no-multiline-string | |||
statusBar.text = `$(browser) Open in browser`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use ' instead of ` here, then // tslint:disable-next-line:no-multiline-string
can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! will try
src/Tomcat/TomcatController.ts
Outdated
this._tomcat.saveServerListSync(); | ||
this._outputChannels.forEach((value: vscode.OutputChannel, key: string) => value.dispose()); | ||
} | ||
|
||
private stopServers(): void { | ||
const serverList: TomcatServer[] = this._tomcat.getServerSet(); | ||
serverList.forEach((value: TomcatServer, index: number, array: TomcatServer[]) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
param index
and array
never used, should be removed?