Fix child process issue, and use shorter name of the open in browser … #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
adashen
commented
Dec 8, 2017
adashen
commented
- Use "Open in browser" as the open web page button and use tooltip to show the full url to fix issue Open web page button will be hidden by debug button in status bar #7
- Stop all the running tomcat when deactivate the extension to fix issue tomcat still running after close vscode #6
jdneo
reviewed
Dec 8, 2017
src/Tomcat/TomcatController.ts
Outdated
| @@ -204,7 +214,9 @@ export class TomcatController { | |||
|
|
|||
| // tslint:disable-next-line:no-http-string | |||
| const serviceuri: string = `http://localhost:${serverPort}/${appName}`; | |||
| statusBar.text = `Open http://localhost:${serverPort}/${appName}`; | |||
| // tslint:disable-next-line:no-multiline-string | |||
| statusBar.text = `$(browser) Open in browser`; | |||
There was a problem hiding this comment.
I think we can use ' instead of ` here, then // tslint:disable-next-line:no-multiline-string can be removed.
Eskibear
reviewed
Dec 8, 2017
src/Tomcat/TomcatController.ts
Outdated
| this._tomcat.saveServerListSync(); | ||
| this._outputChannels.forEach((value: vscode.OutputChannel, key: string) => value.dispose()); | ||
| } | ||
|
|
||
| private stopServers(): void { | ||
| const serverList: TomcatServer[] = this._tomcat.getServerSet(); | ||
| serverList.forEach((value: TomcatServer, index: number, array: TomcatServer[]) => { |
There was a problem hiding this comment.
param index and array never used, should be removed?
Eskibear
approved these changes
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.