Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Remove Columns #1442

Closed
1 of 11 tasks
madhan-dhamodaran opened this issue Dec 19, 2018 · 10 comments
Closed
1 of 11 tasks

Add/Remove Columns #1442

madhan-dhamodaran opened this issue Dec 19, 2018 · 10 comments

Comments

@madhan-dhamodaran
Copy link

madhan-dhamodaran commented Dec 19, 2018

  • Have you already searched for similar issues? Please help us out and double-check first!

  • Also, please don't be that person who deletes this template. It's here for a reason.

  • Thanks!


Which version of React JS are you using?

✅ Officially supported ✅

  • v15.4.x

⚠️ Not officially supported, expect warnings ⚠️

  • v15.5.x
  • v15.6.x

☣️ Not officially supported, expect warnings and errors ☣️

  • v16.x.x

Which browser are you using?

✅ Officially supported ✅

  • IE 9 / IE 10 / IE 11
  • Edge
  • Chrome

⚠️ Not officially supported, but "should work" ⚠️

  • Firefox
  • Safari

I'm submitting a ...

  • 🐛 Bug Report
  • 💡 Feature Request

👋 Need general support? Not sure about how to use React itself, or how to get started with the Grid?
Please do not submit support request here. Instead see

https://github.com/adazzle/react-data-grid/blob/master/CONTRIBUTING.md


Issue Details

Please include:
- What the current behavior is
- What the desired behvaior is
- (If Bug) Steps to reproduce the issue
- (If Feature) The motivation / use case for the feature

We especially love screenshots / videos of problems, and remember
The Best Issue Is A Pull Request™

@amanmahajan7 @rozeskjm @azu

Hi All,

This is a feature proposal.

I would like to add a feature to provide the user the ability to customize the columns that they want to display.

Basically, if they have to show around 50 columns, they can decide to show just 5 and the rest would be unselected and displayed in an adjacent section.

They can go ahead and choose to add that column.

Thanks,
Madhan

@madhan-dhamodaran
Copy link
Author

Creating a new issue because the old one was closed. Will raise a PR for this before end of January 2019

@stale
Copy link

stale bot commented Jan 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please reopen this if you feel it has been incorrectly closed and we will do our best to look into it. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 18, 2019
@madhan-dhamodaran
Copy link
Author

I have raised a PR for this. Awaiting merge. #1449

@stale stale bot removed the wontfix label Jan 18, 2019
@stale
Copy link

stale bot commented Feb 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please reopen this if you feel it has been incorrectly closed and we will do our best to look into it. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 17, 2019
@madhan-dhamodaran
Copy link
Author

I have raised a PR for this. Awaiting merge. #1449

@stale
Copy link

stale bot commented Mar 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please reopen this if you feel it has been incorrectly closed and we will do our best to look into it. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 20, 2019
@madhan-dhamodaran
Copy link
Author

I have raised a PR for this. Awaiting merge. #1449

@stale stale bot removed the wontfix label Mar 20, 2019
@stale
Copy link

stale bot commented Apr 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please reopen this if you feel it has been incorrectly closed and we will do our best to look into it. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 19, 2019
@madhan-dhamodaran
Copy link
Author

I have raised a PR for this. Awaiting merge. #1449

@stale stale bot removed the wontfix label Apr 19, 2019
@amanmahajan7
Copy link
Contributor

We want to keep the grid api flexible so it can cater to multiple use cases. It is fairly simple to move the column selection logic outside the grid so at this moment we won't be adding this feature to the grid. Thank you for the PR

const [columns, setColumns] = useState(...);
return (
  <ColumnSelector onChange={setColumns} />
 <DataGrid rows={rows} columns={columns} />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants