PR for Issues (https://github.com/adazzle/react-data-grid/issues/1441, https://github.com/adazzle/react-data-grid/issues/1442, https://github.com/adazzle/react-data-grid/issues/1400, https://github.com/adazzle/react-data-grid/issues/1181, https://github.com/adazzle/react-data-grid/issues/1443) #1449

madhan-dhamodaran · 2019-01-10T15:30:31Z

Description

A few sentences describing the overall goals of the pull request's commits.

Please check if the PR fulfills these requirements

The commit message follows our guidelines: https://github.com/adazzle/react-data-grid/blob/master/CONTRIBUTING.md
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ X] Feature
[ ] Code style update (formatting, local variables)
[ X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

* TypeAheadFilterChanges * Added Add/Remove Columns Feature * Checked in typeahead filters * Fixed some console errors * Fixed async typeahead filters * upgraded react-select

madhan-dhamodaran · 2019-01-10T15:32:51Z

I will be working on resolving the conflicts and meeting the other requirements.

Thanks,
Madhan

madhan-dhamodaran · 2019-01-18T17:27:10Z

packages/react-data-grid/src/Grid.js

@@ -141,6 +141,13 @@ class Grid extends React.Component {
    this.emptyView = emptyView;
  };

+  getHeaderScroll = () => {
+    if(typeof(this.props.enableHeaderScroll) === 'undefined' || this.props.enableHeaderScroll) {


This fixes the issue when you are on right most of the grid and try to scroll down on a filter dropdown using the scroll bar, it pushes the user to the left most of the grid.

madhan-dhamodaran · 2019-01-18T17:36:03Z

@amanmahajan7 @jlbooker @Jcholerton-Adazzle ,

Hi All, this is a major change and I have introduced a lot of features to the grid. Please have a review and let me know if you have any comments.

Thanks,
Madhan

madhan-dhamodaran · 2019-01-28T16:35:25Z

@amanmahajan7 @jlbooker @Jcholerton-Adazzle , @alefherrera @tenpaiyomi @azu @maiis @txm @LittleBoxOfSunshine , Was anyone able to look into this PR pls.

richardware · 2019-01-29T18:21:05Z

Hi @madhan-dhamodaran,

Sorry you haven't yet had any feedback on this.

It all looks interesting, but it's very difficult to review in the current format - is there a reason why this couldn't be split in to one PR per issue?

madhan-dhamodaran · 2019-02-06T14:54:22Z

hi @richardware ,

Sorry for the late reply. This is worked for almost the whole last year and I incorrectly created a branch out from my fork and had individuals PRs raised and realized they were going to be merged only to my fork. So, when I merged it, everything just formed a huge change list. So here we are now. However, I have introduced a lot of features to the grid. So, if someone could review this and take it to next step, it will be really helpful. Sorry again for the huge number of changes in just one PR. Kindly do the needful.

Thanks,
Madhan

l-wagner · 2019-02-06T19:14:39Z

To show some user interest: The typeahead filter, the tooltip headers and the react-select upgrade are features/improvements that would make my life a lot easier. I understand that it's a vast amount of changes to review, but I'd very much appreciate it. :)

madhan-dhamodaran · 2019-02-15T16:50:22Z

@amanmahajan7 @jlbooker @Jcholerton-Adazzle , @alefherrera @tenpaiyomi @azu @maiis @txm @LittleBoxOfSunshine @richardware , Hey guys, was anyone able to look in to this?

Kindly advise.

Thanks,
Madhan

amanmahajan7 · 2019-02-20T00:35:18Z

Hi @madhan-dhamodaran thank you so much for the PR and apologizes for the late reply. Unfortunately this PR cannot be reviewed in its current state and we need to break it down into separate PRs so things can be reverted/fixed in isolation.

We are also considering retiring some of the existing addons and instead focus on making RDG more flexible so users can customize it however they like. There are a few reasons behind this decision

Addons are not actively maintained
It is impossible to handle every use case

#1441 Typeahead Filter is great but as I mentioned previously it will be hard to address every use case. I would recommend adding this filter to a new repository and publish it separately

#1442 Add/Remove Columns another great feature but I think it does not need to part of core RDG repository

#1181 - Same reasoning

#1400 - Will accept PR

#1443 - set default filtering values in filter text boxes Will accept PR

Thank you again

dsadaka · 2019-03-19T01:32:01Z

Hello everyone. I am tasked with adding saved filters from cookies. I read about PR 1443 and it looks like exactly what I need. I see from above that it was accepted but, as of this writing, is still open. We're about to upgrade the grid to the latest version and are looking forward to this feature (along with the fix to the checkbox column when filtering).

Can anyone please provide a status for 1443?

BlaineBradbury · 2019-04-17T22:24:40Z

@amanmahajan7 are you able to review this one? Especially for the #1400 bug.

starkysclub · 2019-06-26T13:18:57Z

Hey guys I separated the #1400 bug to a new pull request, so it can get merged more quickly, can you look into it?

amanmahajan7 · 2021-05-21T18:04:53Z

Closing this PR as we have decided to keep the react-grid-code slim so all the filters/editors should be implemented externally.

https://github.com/adazzle/react-data-grid/blob/canary/CHANGELOG.md
https://adazzle.github.io/react-data-grid/canary/?path=/story/demos--common-features
https://github.com/adazzle/react-data-grid/tree/canary/stories/demos

madhan-dhamodaran and others added 10 commits November 13, 2018 16:45

Type ahead filter (#1)

0ad71ca

* TypeAheadFilterChanges * Added Add/Remove Columns Feature * Checked in typeahead filters * Fixed some console errors * Fixed async typeahead filters * upgraded react-select

got latest from aDazzle

c1c72ab

upgraded react-select

d9375f8

Added a flag to enable reset to defaults

51c4e18

got latest from aDazzle

970fdbd

fixed an issue with the filterable header cell

fd0832e

Got latest from aDazzle

ed3dd99

Merge branch 'master' of https://github.com/adazzle/react-data-grid

24f39db

Fixed an issue with Draggable and Resizable column and retain textfiltr

cbee8f4

Added tooltip for header. Made the add/remove icons clickable

6a438f0

madhan-dhamodaran added 5 commits January 10, 2019 10:33

Fixed clearing off Text Filters

b91a445

Resolved conflicts

aa2bab7

Refactored the add/remove columns

a35242f

Fixed failing tests and fixed esLint issues

d170cd5

Added tests for AddorRemoveColumns feature

c12e46f

This was referenced Jan 18, 2019

Show filter text boxes and set default filtering values in filter text boxes when initializing #1443

Closed

Populating Dropdown Values for multi-select #1181

Closed

Add/Remove Columns #1442

Closed

Typeahead Filter #1182 #1441

Closed

Added more tests and refactored a little bit code

9070c34

madhan-dhamodaran commented Jan 18, 2019

View reviewed changes

This was referenced Jan 28, 2019

Draggable and Resizable columns Visually expands width to a max limit and then starts to resize. #1400

Closed

On doubleClick show custom editor instead of custom formatter (need example) #1143

Closed

madhan-dhamodaran added 2 commits April 11, 2019 15:38

merged latest from root

debcc0e

packagelock

8dee09f

starkysclub mentioned this pull request Jun 26, 2019

fix resizing of draggable header cell #1700

Closed

1 task

Base automatically changed from master to main January 19, 2021 20:20

amanmahajan7 closed this May 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR for Issues (https://github.com/adazzle/react-data-grid/issues/1441, https://github.com/adazzle/react-data-grid/issues/1442, https://github.com/adazzle/react-data-grid/issues/1400, https://github.com/adazzle/react-data-grid/issues/1181, https://github.com/adazzle/react-data-grid/issues/1443) #1449

PR for Issues (https://github.com/adazzle/react-data-grid/issues/1441, https://github.com/adazzle/react-data-grid/issues/1442, https://github.com/adazzle/react-data-grid/issues/1400, https://github.com/adazzle/react-data-grid/issues/1181, https://github.com/adazzle/react-data-grid/issues/1443) #1449

madhan-dhamodaran commented Jan 10, 2019 •

edited

madhan-dhamodaran commented Jan 10, 2019

madhan-dhamodaran Jan 18, 2019

madhan-dhamodaran commented Jan 18, 2019

madhan-dhamodaran commented Jan 28, 2019

richardware commented Jan 29, 2019

madhan-dhamodaran commented Feb 6, 2019

l-wagner commented Feb 6, 2019

madhan-dhamodaran commented Feb 15, 2019

amanmahajan7 commented Feb 20, 2019

dsadaka commented Mar 19, 2019

BlaineBradbury commented Apr 17, 2019

starkysclub commented Jun 26, 2019

amanmahajan7 commented May 21, 2021

Conversation

madhan-dhamodaran commented Jan 10, 2019 • edited

Description

madhan-dhamodaran commented Jan 10, 2019

madhan-dhamodaran Jan 18, 2019

Choose a reason for hiding this comment

madhan-dhamodaran commented Jan 18, 2019

madhan-dhamodaran commented Jan 28, 2019

richardware commented Jan 29, 2019

madhan-dhamodaran commented Feb 6, 2019

l-wagner commented Feb 6, 2019

madhan-dhamodaran commented Feb 15, 2019

amanmahajan7 commented Feb 20, 2019

dsadaka commented Mar 19, 2019

BlaineBradbury commented Apr 17, 2019

starkysclub commented Jun 26, 2019

amanmahajan7 commented May 21, 2021

madhan-dhamodaran commented Jan 10, 2019 •

edited