React 16 upgrade #1116
React 16 upgrade #1116
Conversation
React 16 React Router 4 Use a single page for docs/examples/home page instead of using separate html files
…used for all the examples and docs
| @@ -6,10 +6,7 @@ const config = { | |||
| 'react-data-grid-addons/dist/react-data-grid-addons': ['./packages/react-data-grid-addons/src'], | |||
| 'react-data-grid/dist/react-data-grid.min': ['./packages/react-data-grid/src'], | |||
| 'react-data-grid-addons/dist/react-data-grid-addons.min': ['./packages/react-data-grid-addons/src'], | |||
| 'react-data-grid-examples/dist/shared': './packages/react-data-grid-examples/src/shared.js', | |||
| 'react-data-grid-examples/dist/examples': './packages/react-data-grid-examples/src/examples.js', | |||
There was a problem hiding this comment.
A single index page is now being used instead of three separate pages (index, examples, and documentation)
| @@ -86,7 +86,7 @@ describe('Grid', function() { | |||
| }; | |||
|
|
|||
| this.componentWrapper = this.createComponent(); | |||
| this.component = this.componentWrapper.node; | |||
| this.component = this.componentWrapper.instance(); | |||
There was a problem hiding this comment.
node is a private property and an error is thrown in V3
| @@ -1,95 +0,0 @@ | |||
| import ReactPerf from 'react-addons-perf'; | |||
There was a problem hiding this comment.
Removed these tests as react-addons-perf is no longer supported
| .keyDown({ | ||
| keyCode: letterEKeyCode | ||
| }, gridRunner.cell ) | ||
| .resetCell(coords) |
There was a problem hiding this comment.
Caching does not work in V3 so resetting cell after each operation
| @@ -113,7 +113,8 @@ class FocusableComponentTestRunner { | |||
| expect(this.componentPrototype.focus).not.toHaveBeenCalled(); | |||
| }); | |||
|
|
|||
| it('should focus when scrolling and selected', () => { | |||
| // TODO: why is this test failing? | |||
| xit('should focus when scrolling and selected', () => { | |||
There was a problem hiding this comment.
This does not seem like a correct test. focusableComponentWrapper does not update if the selection is not changed and when isScrolling state is change this does not trigger a re-render so focus is never called. Is the focusableComponentWrapper working as expected? I am also not sure how was this test passing at the first place, may be because of the experimental lifecycleExperimental flag
There was a problem hiding this comment.
I think we should remove this test, rather than ignoring it. I dont think it is correct either
There was a problem hiding this comment.
I have removed the test
|
|
||
| Enzyme.configure({ | ||
| adapter: new Adapter(), | ||
| disableLifecycleMethods: true |
There was a problem hiding this comment.
Need this flag to keep v2 behavior.
| import { DragDropContext } from 'react-dnd'; | ||
| import HTML5Backend from 'react-dnd-html5-backend'; | ||
|
|
||
| export default DragDropContext(HTML5Backend); |
There was a problem hiding this comment.
react-dnd throws and an error if DragDropContext is initialized with HTML5Backend twice
|
Is this done? Are there are issue? |
Description
A few sentences describing the overall goals of the pull request's commits.
react-input-resizereact-addons-perfas it is no longer supportedPlease check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
React Context Menu: #1081
Other information: