Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DropTargetRowContainer static styles to CSS class for user customization #1308

Merged
merged 3 commits into from
Nov 13, 2018

Conversation

tenpaiyomi
Copy link
Contributor

Description

Updates the DropTargetRowContainer to change the div to have a defined className, allowing for users to modify the CSS styling as desired.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

DropTargetRowContainer defined its CSS style rules inline, making them unable to be changed easily.

What is the new behavior?

Outside of top and height, which are defined from props, the rest of the CSS rules have been moved into react-data-grid-drop-target.css under a class name of rowDropTarget. This allows a user to define a CSS rule and create their own styles. The functionality of everything remains the same.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@malonecj malonecj merged commit 2e153ae into adazzle:master Nov 13, 2018
rossjp pushed a commit to rossjp/react-data-grid that referenced this pull request Dec 14, 2018
…mization (adazzle#1308)

* Adding a class to the drop target row container that allows the user to restyle

* Updating the css

* Use className instead of class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants