Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of i for column index which is no longer passed in #1344

Merged
merged 1 commit into from Nov 13, 2018

Conversation

Projects
None yet
2 participants
@mungojam
Copy link
Contributor

mungojam commented Oct 28, 2018

Description

In a previous PR, the column index i had been partly replaced. However, it wasn't fully rolled out, so the fallback to using the column index as the key is no longer working. This was part of the cause of #1343

This PR fully implements the replacement of i with column.idx.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Nested arrays cannot be displayed correctly in a Grid since v5

What is the new behavior?
Nested arrays can now be displayed

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@malonecj malonecj merged commit 5856616 into adazzle:master Nov 13, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

rossjp added a commit to rossjp/react-data-grid that referenced this pull request Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.