Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cell focusing logic #1352

Merged
merged 3 commits into from Oct 31, 2018

Conversation

Projects
None yet
3 participants
@amanmahajan7
Copy link
Contributor

amanmahajan7 commented Oct 30, 2018

Currently when a cell is selected, the scroll position is preserved before the focus and reapplied after the cell is focused. This is unnecessary and can cause janky behavior. The correct way is to focus on the SelectionMask element instead of the container element.

Thanks to @MayhemYDG for the tip.

Remove the hack to preserve scroll position
Focus the selection mask instead of parent node

@amanmahajan7 amanmahajan7 requested a review from malonecj Oct 30, 2018

@amanmahajan7 amanmahajan7 requested a review from MayhemYDG Oct 30, 2018

@malonecj malonecj merged commit 7b5ad6f into master Oct 31, 2018

2 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@MayhemYDG MayhemYDG deleted the am-improve-editor-focus branch Oct 31, 2018

malonecj added a commit that referenced this pull request Nov 15, 2018

Fix cell focusing logic (#1352)
* Remove the hack to preserve scroll position
Focus the selection mask instead of parent node

* Fix unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.