Cleanup zIndex logic #1393
Merged
Cleanup zIndex logic #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesPortelli
approved these changes
Nov 22, 2018
nstepien
approved these changes
Nov 22, 2018
rossjp
pushed a commit
to rossjp/react-data-grid
that referenced
this pull request
Dec 14, 2018
* Refactor zIndex logic * Fix unit tests * Fix frozen cells filtering
|
Many admin-panel theme already have it's z-index hierarchy, mostly from 1 to 10. This low zIndex logic may failed once we are using react-data-grid inside it. I was using .css to override it (e.g. .rdg-editor-container { z-index: 5 !important;} ) but this is not a good solution. can we add an offset, e.g. 10 to avoid this conflict ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EditorContainerzIndex as is rendered outside the gridhttps://www.useloom.com/share/c2a82eb341dc4a639c72f679d681cc52