Enable the no-undef rule #1397
Merged
Enable the no-undef rule #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstepien
requested changes
Nov 26, 2018
| @@ -1,5 +1,7 @@ | |||
| const React = require('react'); | |||
| import PropTypes from 'prop-types'; | |||
| import moment from 'moment'; | |||
|
|
|||
| const ReactDOM = require('react-dom'); | |||
| const Moment = require('moment'); | |||
There was a problem hiding this comment.
Should avoid importing it twice.
There was a problem hiding this comment.
This file should be deleted as it is not used and maintained. I am going to create a separate PR to removed unused files once this is merged
|
You should also double check that the environments are set up properly in eslint, so we don't allow |
|
I will cleanup cleanup eslint file in a separate PR as well :) |
nstepien
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.