tsify ColumnComparer #1576
Merged
tsify ColumnComparer #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstepien
commented
Apr 11, 2019
| for (const k in a) { | ||
| if (a.hasOwnProperty(k)) { | ||
| const valA = a[k] as unknown; | ||
| const valB = b[k as string as keyof B] as unknown; |
There was a problem hiding this comment.
Without the as string as keyof B part:
Without at least one as unknown:
| @@ -0,0 +1,24 @@ | |||
| import { isElement } from 'react-is'; | |||
|
|
|||
| export function sameColumn<A, B>(a: A, b: B): boolean { | |||
There was a problem hiding this comment.
We should probably replace the generic types once we know how this function is used.
amanmahajan7
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might want to revisit the types when we know more about how
sameColumnis used.