Remove setScrollLeft on Row and Cell #1793
Conversation
| ref={this.copyMask} | ||
| /> | ||
| )} | ||
| {copiedPosition && <CopyMask {...this.getSelectedDimensions(copiedPosition)} />} |
There was a problem hiding this comment.
what is the CopyMask? Like ctrl c / ctrl v background?
There was a problem hiding this comment.
A mask that appears when you copy a cell.
| return <Renderer key={`${key as keyof R}-${idx}`} {...cellProps} />; // FIXME: fix key type | ||
| } | ||
| // FIXME: do we need this, considering columnsMetrics should have these columns sorted already? | ||
| const frozenColumns = columns.slice(0, this.props.lastFrozenColumnIndex + 1); |
There was a problem hiding this comment.
I remember I tried in my local that to put frozenColumns first and then nonFrozenColumns later. The row cells displaying was screwed up. Not sure why that happened as I didn't take time to investigate.
|
Just want to add one more comment that the difference between the existing code and the new code is just the SCU on The bottleneck in IE 11 is after horizontal scrolling. There were bunch of |
scrollLeftprop in IE11, as it's not used in other browsers.shallowequalanymoreshallowequalCellto a stateless functional component.