Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop lerna, start ignoring rdg-addons #1843

Merged
merged 15 commits into from Dec 16, 2019
Merged

Drop lerna, start ignoring rdg-addons #1843

merged 15 commits into from Dec 16, 2019

Conversation

nstepien
Copy link
Contributor

@nstepien nstepien commented Dec 12, 2019

I think we can stop working on rdg-addons now. We can keep using the previously published versions until we completely integrate its features into the main package.

  • Started using some ES modules for our node scripts, so make sure you're on the latest Node.js version
  • Deleted the .github/ files. The repo's not in a state where we can provide proper support, so I feel like the templates were not useful as they were, and are not as relevant as before. We'll add them back once we have an actual stable version we can support.
  • packages/react-data-grid-addons/ is still there, but it'll now be ignored by the tools like eslint and we won't build it anymore.
  • npm start works without having to build the lib all the time.
    • TS-only now, JS is not allowed anymore.

  • Merge the READMEs
  • Fix publishing guide in CONTRIBUTING.md
  • Should we finish porting the examples to TS?

@nstepien nstepien self-assigned this Dec 12, 2019
@amanmahajan7
Copy link
Contributor

@MayhemYDG I think we can create pre-canary branch as there are many PRs that will be ready soon. It will probably be better to start merging things so there are less conflicts

@nstepien
Copy link
Contributor Author

Sure, you can go ahead, or I'll do it tomorrow morning.

@qili26
Copy link
Contributor

qili26 commented Dec 13, 2019

Do we want to finish this PR first and then do the removal? It's working in my local and I just need to do some cleanup.

#1841

@nstepien nstepien changed the base branch from canary to pre-canary December 13, 2019 11:38
@nstepien
Copy link
Contributor Author

I'm fine doing it either way.

@nstepien nstepien marked this pull request as ready for review December 14, 2019 00:13
@nstepien nstepien requested a review from qili26 December 14, 2019 00:13
@nstepien
Copy link
Contributor Author

@qili26 @amanmahajan7 since I'm off until January maybe we could merge this now, and we'll check the dnd PR later?

@amanmahajan7
Copy link
Contributor

amanmahajan7 commented Dec 15, 2019

Is this PR ready? Looks like we have commented some code including examples

@nstepien
Copy link
Contributor Author

It's ready for review. I've made it so running the examples will only allow ts (from src or examples) from now on, so I haven't TSified all the examples yet, as we can do it later as we need it. Also to avoid git conflicts.

@amanmahajan7
Copy link
Contributor

I will check

Copy link
Contributor

@amanmahajan7 amanmahajan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nstepien nstepien merged commit 6e752d9 into pre-canary Dec 16, 2019
@nstepien nstepien deleted the lerna-no-more branch December 16, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants