New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop lerna, start ignoring rdg-addons #1843
Conversation
@MayhemYDG I think we can create |
Sure, you can go ahead, or I'll do it tomorrow morning. |
Do we want to finish this PR first and then do the removal? It's working in my local and I just need to do some cleanup. |
I'm fine doing it either way. |
fe402d5
to
9766dbe
Compare
@qili26 @amanmahajan7 since I'm off until January maybe we could merge this now, and we'll check the dnd PR later? |
Is this PR ready? Looks like we have commented some code including examples |
It's ready for review. I've made it so running the examples will only allow ts (from src or examples) from now on, so I haven't TSified all the examples yet, as we can do it later as we need it. Also to avoid git conflicts. |
I will check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I think we can stop working on rdg-addons now. We can keep using the previously published versions until we completely integrate its features into the main package.
.github/
files. The repo's not in a state where we can provide proper support, so I feel like the templates were not useful as they were, and are not as relevant as before. We'll add them back once we have an actual stable version we can support.packages/react-data-grid-addons/
is still there, but it'll now be ignored by the tools like eslint and we won't build it anymore.npm start
works without having to build the lib all the time.