Fix for Copy&Paste events not working properly in non-English keyboard event #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstepien
approved these changes
Oct 21, 2020
|
LGTM, thanks! I'd rather not use https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent |
amanmahajan7
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ctrl+V and Ctrl+C events are not detected when the keyboard language is not set on English. The condition for the copy/paste event is if event.code equals to 'c' or 'v'. This results in the non-English character showing the the selected cell instead of triggering a copy/paste event. For example 'C' in Hebrew is 'ב':
The suggested commit is using event.keyCode (cKey = 67, vKey = 86) instead of event.code to detect the event in non-English keyboard layouts.