Handle focus on focusable formatters #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanmahajan7
commented
Jul 28, 2020
| export function SelectCellFormatter({ value, tabIndex, isCellSelected, disabled, onChange }: SelectCellFormatterProps) { | ||
| const inputRef = useRef<HTMLInputElement>(null); | ||
| useEffect(() => { | ||
| if (isCellSelected) { |
There was a problem hiding this comment.
User can handle focus however they like and event can be stopped from propagating for complex components.
nstepien
requested changes
Jul 29, 2020
| return ( | ||
| <> | ||
| <div className="rdg-child-row-action-cross" /> | ||
| {isDeleteSubRowEnabled && ( | ||
| <div className="rdg-child-row-btn" onClick={onDeleteSubRow}> | ||
| ❌ | ||
| <span |
There was a problem hiding this comment.
Why add another element?
Also I think if you just set onClick={onDeleteSubRow} instead of handling onKeyDown manually it might work just as well.
There was a problem hiding this comment.
Otherwise it looks like this
nstepien
approved these changes
Jul 29, 2020
qili26
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.w3.org/TR/wai-aria-practices/#gridNav_focus
https://www.loom.com/share/3a0e559f0ea04db98226c3169dffad04