Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editorPortalTarget default value for server-side rendering #2245

Merged
merged 3 commits into from
Dec 3, 2020
Merged

Fix editorPortalTarget default value for server-side rendering #2245

merged 3 commits into from
Dec 3, 2020

Conversation

nstepien
Copy link
Contributor

@nstepien nstepien commented Dec 3, 2020 •
edited

document doesn't exist in node.

> node .\test.js
file:///D:/repos/react-data-grid/lib/bundle.js:1377
  editorPortalTarget = document.body,

ReferenceError: document is not defined

https://reactjs.org/docs/react-dom-server.html

@nstepien nstepien self-assigned this Dec 3, 2020
@nstepien nstepien marked this pull request as ready for review December 3, 2020 14:19
@nstepien nstepien merged commit 2579d2b into canary Dec 3, 2020
@nstepien nstepien deleted the ssr branch December 3, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanmahajan7 amanmahajan7 amanmahajan7 approved these changes

Assignees

@nstepien nstepien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nstepien @amanmahajan7