Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Augment onRowsChange with indexes and column data #2278

Merged
merged 4 commits into from
Jan 15, 2021
Merged

Augment onRowsChange with indexes and column data #2278

merged 4 commits into from
Jan 15, 2021

Conversation

nstepien
Copy link
Contributor

cc @ekeuus

@nstepien nstepien self-assigned this Jan 14, 2021
@nstepien nstepien enabled auto-merge (squash) January 14, 2021 18:29
@ekeuus
Copy link
Contributor

ekeuus commented Jan 14, 2021

I think it looks good to me! I can just easily create a wrapper to extract the changed column value now easily 😉

amanmahajan7
amanmahajan7 approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@amanmahajan7 amanmahajan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚢

@nstepien nstepien merged commit d7095c5 into canary Jan 15, 2021
@nstepien nstepien deleted the indexes branch January 15, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanmahajan7 amanmahajan7 amanmahajan7 approved these changes

Assignees

@nstepien nstepien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nstepien @ekeuus @amanmahajan7