Use context for selection #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstepien
reviewed
Mar 18, 2021
There was a problem hiding this comment.
Can't we just render the providers in DataGrid once?
That way we can avoid Row re-renders perhaps.
We might trigger formatter re-renders more often, but it's probably still less heavy since it's only for the few formatters that are in the viewport, and are using the contexts.
Row selection values won't change often anyway.
src/hooks/useRowSelection.ts
Outdated
| @@ -0,0 +1,12 @@ | |||
| import { createContext, useContext } from 'react'; | |||
|
|
|||
| export const RowSelectionContext = | |||
There was a problem hiding this comment.
Let's export the Provider directly here instead, that way we save a property access during render.
Also can we merge the two contexts into one?
src/hooks/useRowSelectionChange.ts
Outdated
| @@ -0,0 +1,12 @@ | |||
| import { createContext, useContext } from 'react'; | |||
|
|
|||
| export const RowSelectionChangeContext = | |||
|
Before After This profile is for selecting/deselecting all rows. |
nstepien
requested changes
May 13, 2021
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
nstepien
previously approved these changes
May 13, 2021
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select all operation
Before
After
