ResizeObserver: Add workaround for odd grid dimensions and zoom levels leading to "flickering" scrollbars #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s leading to "flickering" scrollbars
amanmahajan7
approved these changes
May 6, 2021
gernotkogler
pushed a commit
to Garaio-REM/react-data-grid
that referenced
this pull request
May 13, 2021
…s leading to "flickering" scrollbars (adazzle#2389)
|
We are still seeing this in production for Windows users. Should the fix rather be to round the width down/up always to prevent the flickering? The modulo of 0.5 seems kind of strange and highly specific imo. I am unable to reproduce it even in a windows VM so I do not know the exact steps to repro. If either of you knows how to reproduce it code-wise, I would happily write tests and fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.