Fix #515, column header misalignment #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2016 12:18
…f the value of the column's left property has changed
|
Changes Unknown when pulling 1e71e83 on supamanda:ah-515-column-header-misaligned into * on adazzle:master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix for #515
If the column width isn't specified, the ColumnMetrics will recalculate the width and the left position of each of the columns. Originally, the column header was only triggering an update if the column width was changed, but not if the left position was changed.
This PR has changed the HeaderCell's shouldComponentUpdate method to return true if the column's left property has changed, and I've set up tests to confirm the behaviour of the shouldComponentUpdate method.
Does this PR introduce a breaking change? (check one with "x")