Add componentWillReceiveProps to CellExpand #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogofcunha
suggested changes
Jul 6, 2017
| testElement.simulate('click'); | ||
| expect(testElement.state('expanded')).toBeTruthy(); | ||
| let secondProps = getFakeProps(false); | ||
| testElement = renderComponent(secondProps); |
There was a problem hiding this comment.
This creates a new component, use testElement.setProps
| @@ -6,6 +6,9 @@ const CellExpand = React.createClass({ | |||
| let expanded = this.props.expandableOptions && this.props.expandableOptions.expanded; | |||
| return { expanded: expanded }; | |||
| }, | |||
| componentWillReceiveProps(nextProps) { | |||
| this.setState(nextProps.props.expandableOptions && nextProps.props.expandableOptions.expanded); | |||
There was a problem hiding this comment.
what is this fancy thing?
|
Changes Unknown when pulling 001e9f5 on dm-fix-subrow-state into ** on master**. |
|
Changes Unknown when pulling 2992dc0 on dm-fix-subrow-state into ** on master**. |
diogofcunha
approved these changes
Jul 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add componentWilLReceiveProps to CellExpand in order to update the state when receiving the *expanded" from external data.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior?
The subrow icon only changes with the click event.
What is the new behavior?
It will continue to change on the click event but also change when receiving the information by props.
Does this PR introduce a breaking change?