Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select All functionality is inconsistent if we have multiple… #867

Closed
wants to merge 1 commit into from

Conversation

samirraorane
Copy link

@samirraorane samirraorane commented Jul 12, 2017

… grids on the same page. Removing the id from the input element solves the issue.

Description

Fix the Select All functionality when multiple grids are displayed on the page.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
With two grids on the same page, the Select All checkbox on the second grid selects all rows on the first grid.

What is the new behavior?
Select All checkbox when checked will select/deselect rows from the same grid.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

… grids on the same page. Removing the id from the input element solves the issue.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 48699ed on Select_All_Multiple_Grids into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 48699ed on Select_All_Multiple_Grids into ** on master**.

@samirraorane samirraorane changed the title FIT-349: Select All functionality is inconsistent if we have multiple… Select All functionality is inconsistent if we have multiple… Jul 12, 2017
@samirraorane
Copy link
Author

Closing this PR.. created a new one - #868

@samirraorane samirraorane deleted the Select_All_Multiple_Grids branch July 12, 2017 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants