Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer URL management to courlan.UrlStore (experimental) #232

Merged
merged 16 commits into from
Feb 6, 2023
Merged

Conversation

adbar
Copy link
Owner

@adbar adbar commented Aug 2, 2022

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Aug 2, 2022

This pull request introduces 11 alerts when merging 8f06753 into 20dba19 - view on LGTM.com

new alerts:

  • 6 for Unused local variable
  • 5 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Aug 2, 2022

This pull request introduces 9 alerts when merging c0d1136 into 20dba19 - view on LGTM.com

new alerts:

  • 6 for Unused local variable
  • 3 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Aug 4, 2022

This pull request introduces 9 alerts when merging 23ec71d into 20dba19 - view on LGTM.com

new alerts:

  • 6 for Unused local variable
  • 3 for Unused import

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #232 (9a19d20) into master (822c8b1) will decrease coverage by 0.36%.
The diff coverage is 92.63%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
- Coverage   95.32%   94.96%   -0.36%     
==========================================
  Files          21       21              
  Lines        3313     3256      -57     
==========================================
- Hits         3158     3092      -66     
- Misses        155      164       +9     
Impacted Files Coverage Δ
trafilatura/metaxpaths.py 100.00% <ø> (ø)
trafilatura/spider.py 85.12% <83.72%> (-7.47%) ⬇️
trafilatura/cli.py 93.58% <100.00%> (-0.28%) ⬇️
trafilatura/cli_utils.py 89.90% <100.00%> (-0.38%) ⬇️
trafilatura/downloads.py 96.59% <100.00%> (+0.59%) ⬆️
trafilatura/core.py 96.89% <0.00%> (-0.52%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adbar adbar marked this pull request as draft August 23, 2022 16:01
@adbar adbar linked an issue Jan 4, 2023 that may be closed by this pull request
4 tasks
@adbar adbar marked this pull request as ready for review February 6, 2023 16:33
@adbar adbar merged commit 2571ad1 into master Feb 6, 2023
@adbar adbar deleted the experimental branch February 6, 2023 17:03
adbar added a commit that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: improve usability for large number of downloads
2 participants