Issue 3320 - App killed when launching it #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge with Eyeo upstream
Sync with Eyeo
Sync with Eyeo
Sync with Eyeo
Sync with Eyeo
Sync with Eyeo
Sync with Eyeo
Sync with Eyeo
Sync with Eyeo
|
@fhd: Small fix of incorrect app group id in dev builds. |
| @@ -26,6 +26,8 @@ | |||
| static NSString *AdblockPlusDownloadedVersion = @"AdblockPlusDownloadedVersion"; | |||
| static NSString *AdblockPlusWhitelistedWebsites = @"AdblockPlusWhitelistedWebsites"; | |||
|
|
|||
| static NSString *AdblockPlusSafariExtension = @"AdblockPlusSafariExtension"; | |||
There was a problem hiding this comment.
Is there a reason this is separated from the above by an empty line?
There was a problem hiding this comment.
I wanted to separate this variable, because it has different semantic then values above (it is value and not key used in dictionary).
There was a problem hiding this comment.
Sorry, missed this comment because GitHub didn't send out a notification. Yeah, if it makes sense let's keep it.
|
@dedecej Thanks! Just one nit. |
|
@dedecej Sorry, missed your comment. LGTM! Merging now. |
|
Merged: 3a7b3aa |
abpbot
pushed a commit
that referenced
this pull request
Jun 21, 2018
Also added/corrected some existing header documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue 3320.