Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3320 - App killed when launching it #17

Closed
wants to merge 10 commits into from

Conversation

2 participants
@dedecej
Copy link
Contributor

commented Dec 14, 2015

Related to issue 3320.

@dedecej

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2015

@fhd: Small fix of incorrect app group id in dev builds.

@@ -26,6 +26,8 @@
static NSString *AdblockPlusDownloadedVersion = @"AdblockPlusDownloadedVersion";
static NSString *AdblockPlusWhitelistedWebsites = @"AdblockPlusWhitelistedWebsites";

static NSString *AdblockPlusSafariExtension = @"AdblockPlusSafariExtension";

This comment has been minimized.

Copy link
@fhd

fhd Dec 14, 2015

Member

Is there a reason this is separated from the above by an empty line?

This comment has been minimized.

Copy link
@dedecej

dedecej Dec 14, 2015

Author Contributor

I wanted to separate this variable, because it has different semantic then values above (it is value and not key used in dictionary).

This comment has been minimized.

Copy link
@fhd

fhd Dec 15, 2015

Member

Sorry, missed this comment because GitHub didn't send out a notification. Yeah, if it makes sense let's keep it.

@fhd

This comment has been minimized.

Copy link
Member

commented Dec 14, 2015

@dedecej Thanks! Just one nit.

@fhd

This comment has been minimized.

Copy link
Member

commented Dec 15, 2015

@dedecej Sorry, missed your comment. LGTM! Merging now.

@fhd

This comment has been minimized.

Copy link
Member

commented Dec 15, 2015

Merged: 3a7b3aa

@fhd fhd closed this Dec 15, 2015

abpbot pushed a commit that referenced this pull request Jun 21, 2018

Issue #17 - Rewrote logic for checkActivatedFlag
Also added/corrected some existing header documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.