Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make code more readable #225

Merged
merged 1 commit into from
May 15, 2019
Merged

Make code more readable #225

merged 1 commit into from
May 15, 2019

Conversation

dagwieers
Copy link
Collaborator

We have overly long constructions like:

self._kodiwrapper.get_localized_string()

and this would now become:

self._kodi.localize()

@dagwieers dagwieers added the enhancement New feature or request label May 14, 2019
@dagwieers dagwieers added this to the v1.10.0 milestone May 14, 2019
@dagwieers
Copy link
Collaborator Author

dagwieers commented May 14, 2019

@mediaminister @pietje666 This may be controversial, but it irritates me daily.

@dagwieers dagwieers force-pushed the localize branch 3 times, most recently from 34976a4 to 035bf51 Compare May 15, 2019 12:56
We have overly long constructions like:

    self._kodiwrapper.get_localized_string()

and this would now become:

    self._kodi.localize()
@dagwieers
Copy link
Collaborator Author

For the help information in #231 I need to make some room in the language files.
So for this I plan to reorganize according to: https://github.com/pietje666/plugin.video.vrt.nu/wiki/Translations

So I need to merge this to avoid a very large conflict...

@dagwieers dagwieers merged commit 1561293 into add-ons:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant