Re-add option to disable favorites #231
Conversation
dagwieers
force-pushed
the
favorites-optional
branch
3 times, most recently
from
cafdc49
to
fb22627
Compare
|
@mediaminister Does this help with your concerns, provided we add help information in the Settings. |
dagwieers
force-pushed
the
favorites-optional
branch
4 times, most recently
from
66b9ed4
to
28de194
Compare
This PR includes: - Re-added the settings option to enable/disable favorites - Only enable My programs when settings enable it and credentials are detected - Reorganize unit tests (move from vrtplayer to apihelper)
dagwieers
force-pushed
the
favorites-optional
branch
from
28de194
to
ab6c0b7
Compare
|
It appears that help messages don't work for addon settings, this is something for my list of Kodi shortcomings :-( |
|
Are you sure this works on a fresh Kodi installation? I can't use "my programs" on a fresh install. My main concern is that a new function shouldn't slow down or break the basic functionality of the add-on (for new users):
|
|
@mediaminister If you do not have any credentials, the "My programs" will not appear. As soon as you enter your credentials (and have it enabled in the settings) that menu item should become visible. This is basically what you requested. People can now use the live streams and work as before without credentials. All your considerations are met with this implementation, and it worked fine for me. I now also tested on Windows and discovered an issue with expirationDate when using Dutch Kodi locale (on an English Windows). I have a fix for this. |
|
Thanks for the explanation. It works now after providing credentials. |
|
I appreciate your feedback and help too ! :-) |
This PR includes:
This is done over concerns from #213 (comment)
Additionally, I think we need to add help to individual settings to give a little bit more insight into how settings affect the VRT NU addon. This also gives more maturity to our addon settings pages...