Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio icons in Kodi are missing/ugly #17

Closed
dagwieers opened this issue Jul 9, 2019 · 5 comments
Closed

Studio icons in Kodi are missing/ugly #17

dagwieers opened this issue Jul 9, 2019 · 5 comments
Labels
enhancement New feature or request released A fix for this issue has been merged by upstream
Milestone

Comments

@dagwieers
Copy link
Collaborator

The icons in resource.images.studios.white and resource.images.studios.coloured for Medialaan brands are either missing or outdated.

It could be useful to have them, i.e. they work out-of-the-box with YouTube support, and could be useful in the future for other content as well (if we would have this information per program).

@michaelarnauts
Copy link
Collaborator

The API contains an url to a channel icon for vod content, i don't see a textual representation of the channel.

        "channelLogoUrl": "https://api.vtmgo.be/static/images/logos/vitaya-412f405c5dbc13e88844d8ba20e2e611.png",

@dagwieers
Copy link
Collaborator Author

Right, but I cannot use those for the YouTube channels, whereas if they were part of the Studios icons, they would be available. Currently Estuary has a deficiency and so only the TV shows content view can display studio icons, unless you patch it. The fix will be in Kodi Matrix as they don't backport visual improvements.

@mediaminister
Copy link
Contributor

mediaminister commented Aug 8, 2019

I created pull requests with the logos.
XBMC-Addons/resource.images.studios.white#24
XBMC-Addons/resource.images.studios.coloured#25

@dagwieers dagwieers mentioned this issue Aug 8, 2019
@dagwieers
Copy link
Collaborator Author

This should be fixed and released now. To be tested.

@dagwieers dagwieers added enhancement New feature or request fixed A fix is available upstream but not yet released labels Sep 9, 2019
@dagwieers dagwieers modified the milestones: v0.9.1, v0.9.0 Sep 9, 2019
@dagwieers
Copy link
Collaborator Author

This appears to be fixed. The Youtube menu shows proper icons now.

@dagwieers dagwieers added released A fix for this issue has been merged by upstream and removed fixed A fix is available upstream but not yet released labels May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released A fix for this issue has been merged by upstream
Projects
None yet
Development

No branches or pull requests

3 participants