Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted fixes #41

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Conversation

dagwieers
Copy link
Collaborator

@dagwieers dagwieers commented Aug 8, 2019

This PR includes:

  • Support for studio icons (optional)
  • Add get_cond_visibility() support
  • Renamed /live to /livetv
  • Rewrote plot formatting for programs, episodes, movies and livetv
  • Added studio support
  • Improved geo-blocked support (most, if not all, are not geo-blocked)
  • Use dict get() to avoid potential KeyError
  • Strip episode number from name
  • Add branch name to ZIP file

This fixes #39

@dagwieers dagwieers force-pushed the assorted-fixes branch 9 times, most recently from b7f51e1 to 5b72c83 Compare August 8, 2019 23:20
@dagwieers dagwieers marked this pull request as ready for review August 8, 2019 23:21
@dagwieers
Copy link
Collaborator Author

dagwieers commented Aug 8, 2019

So the optional dependency to the studio icons are disabled currently as the proper icons have not yet been released. Because of this the current result may not look too good if you do have the studio icons installed. But that is just temporary... #17

@dagwieers dagwieers force-pushed the assorted-fixes branch 2 times, most recently from 7a9255d to 601539e Compare August 9, 2019 00:27
This PR includes:
- Support for studio icons (optional)
- Add get_cond_visibility() support
- Renamed /live to /livetv
- Rewrote plot formatting for programs, episodes, movies and livetv
- Added studio support
- Improved geo-blocked support (most, if not all, are not geo-blocked)
- Use dict get() to avoid potential KeyError
- Strip episode number from name
- Add branch name to ZIP file
@michaelarnauts michaelarnauts merged commit 67338e7 into add-ons:master Aug 9, 2019
@michaelarnauts
Copy link
Collaborator

Cool, thanks. I love the » characters btw :)

@dagwieers dagwieers added bug Something isn't working enhancement New feature or request labels Sep 9, 2019
@dagwieers dagwieers added this to the v0.9.0 milestone Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add channel information from "channelLogoUrl"
2 participants