Repaired earnings and financials for certain symbols

docs/source/whatsnew/v0.3.4.txt

@@ -0,0 +1,13 @@
+.. _whatsnew_034:
+
+
+v0.3.4 (TBA)
+-----------------------
+
+This is a minor release from 0.3.4.
+
+Bug Fixes
+~~~~~~~~~
+
+-  Fix KeyError exception when there is no earnings or financials data on a ticker. (Thank you reixd)
+`GH60 <https://github.com/addisonlynch/iexfinance/pull/60>`__

iexfinance/stock.py

@@ -359,7 +359,7 @@ def get_earnings(self, **kwargs):
             Stocks Earnings endpoint data
         """
         data = self._get_endpoint("earnings", kwargs)
-        return {symbol: data[symbol]["earnings"]["earnings"]
+        return {symbol: data[symbol]["earnings"].get("earnings", [])
                 for symbol in list(data)}
 
     @output_format(override=None)
@@ -387,7 +387,7 @@ def get_financials(self, **kwargs):
             Stocks Financials endpoint data
         """
         data = self._get_endpoint("financials", kwargs)
-        return {symbol: data[symbol]["financials"]["financials"]
+        return {symbol: data[symbol]["financials"].get("financials", [])
                 for symbol in list(data)}
 
     @output_format(override=None)

tests/test_stock.py

@@ -41,6 +41,7 @@ def setup_class(self):
         self.cshare4 = Stock("aapl",
                              json_parse_int=Decimal,
                              json_parse_float=Decimal)
+        self.cshare5 = Stock("gig^")
 
     def test_invalid_symbol(self):
         data = Stock("BAD SYMBOL")
@@ -135,6 +136,10 @@ def test_get_earnings_format(self):
         data2 = self.cshare2.get_earnings()
         assert isinstance(data2, pd.DataFrame)
 
+        # Ensure empty list is returned for symbol with no earnings
+        data3 = self.cshare5.get_earnings()
+        assert isinstance(data3, list)
+
     def test_get_effective_spread_format(self):
         data = self.cshare.get_effective_spread()
         assert isinstance(data, list)
@@ -149,6 +154,10 @@ def test_get_financials_format(self):
         data2 = self.cshare2.get_financials()
         assert isinstance(data2, pd.DataFrame)
 
+        # Ensure empty list is returned even when ticker has no financials
+        data3 = self.cshare5.get_financials()
+        assert isinstance(data3, list)
+
     def test_get_key_stats_format(self):
         data = self.cshare.get_key_stats()
         assert isinstance(data, dict)