-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cameras shown have already set correct camera #55
Comments
I didn't understand this issue at first, but I bumped into the same problem, which clarified it: some edits I made with wikicrowd were reverted on Commons because the image already had a "depicts" statement with a Wikidata item that's a subclass/instance of camera. For example, the file File:Samsung NX2000 (White) top.jpg was shown to me in Wikicrowd and I clicked yes, which added a "depicts: camera" statement to it, but it already had a "depicts: Samsung NX2000" statement. |
So the question will not be generated, and also edit will not happen if the file in question has a depicts statement for any item in this list This comes from this code https://github.com/addshore/wikicrowd/blob/main/app/Jobs/GenerateDepictsQuestions.php#L212-L238 The model in question must not meet these criteria
So going all the way up the subclass tree we can get to camera (Q15328) So something is not right :) |
Still present, still problematic https://www.wikidata.org/wiki/Q18354117 |
So taking another look
And this is the top of the tree. I believe this differs from Q51539860 I looked at above in #55 (comment) as that was also subclass of mirrorless interchangeable-lens camera (Q209918) TLDR, the modelling on Wikidata or commons needs to change. Looking at the modeling of a 5D https://www.wikidata.org/wiki/Q64955 So the model should have a subclass of statement It shouldnt appear in questions anymore, as:
|
I got
https://commons.wikimedia.org/wiki/File:Canon_EOS_M50_black_06.jpg
But inside there is already information about "Canon EOS M50".
I remember that I got such situation couple times, but I closed browser. But I am really afraid that I am marking images that have already correct info.
The text was updated successfully, but these errors were encountered: