Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cameras shown have already set correct camera #55

Closed
PiotrGackowski opened this issue Apr 13, 2022 · 5 comments
Closed

Cameras shown have already set correct camera #55

PiotrGackowski opened this issue Apr 13, 2022 · 5 comments
Labels
bug Something isn't working feature-depicts

Comments

@PiotrGackowski
Copy link
Contributor

I got
https://commons.wikimedia.org/wiki/File:Canon_EOS_M50_black_06.jpg
But inside there is already information about "Canon EOS M50".

I remember that I got such situation couple times, but I closed browser. But I am really afraid that I am marking images that have already correct info.

@PiotrGackowski
Copy link
Contributor Author

@waldyrious
Copy link
Contributor

waldyrious commented Apr 14, 2022

I didn't understand this issue at first, but I bumped into the same problem, which clarified it: some edits I made with wikicrowd were reverted on Commons because the image already had a "depicts" statement with a Wikidata item that's a subclass/instance of camera.

For example, the file File:Samsung NX2000 (White) top.jpg was shown to me in Wikicrowd and I clicked yes, which added a "depicts: camera" statement to it, but it already had a "depicts: Samsung NX2000" statement.

@addshore
Copy link
Owner

So the question will not be generated, and also edit will not happen if the file in question has a depicts statement for any item in this list
https://query.wikidata.org/#SELECT%20DISTINCT%20%3Fi%20WHERE%7B%3Fi%20wdt%3AP31%2Fwdt%3AP279%2a%7Cwdt%3AP279%2Fwdt%3AP279%2a%20wd%3AQ15328%20%7D
or this list https://query.wikidata.org/#SELECT%20DISTINCT%20%3Fi%20WHERE%7Bwd%3AQ15328%20wdt%3AP279%2B%20%3Fi%20%7D
Basically looking for trees of items in the class tree from Q15328 as defined in https://github.com/addshore/wikicrowd/blob/main/spec/depicts/misc/camera.yaml#L1

This comes from this code https://github.com/addshore/wikicrowd/blob/main/app/Jobs/GenerateDepictsQuestions.php#L212-L238
trying to cover instancesOfAndSubclassesOf the top level item, and also parentInstancesOfAndSubclassesOf.

The model in question must not meet these criteria
https://www.wikidata.org/wiki/Q51539860
Going up the trees

  • instance of digital camera model (Q20741022)
    • subclass of camera model (Q20888659)
  • subclass of mirrorless interchangeable-lens camera (Q209918)
    • subclass of digital camera (Q62927)
      • subclass of camera (Q15328)

So going all the way up the subclass tree we can get to camera (Q15328)

So something is not right :)

@addshore addshore added bug Something isn't working feature-depicts labels Apr 18, 2022
@PiotrGackowski
Copy link
Contributor Author

@addshore
Copy link
Owner

addshore commented Jun 3, 2022

So taking another look

And this is the top of the tree.
So the tool has no way of knowing that Q18354117 is a camera.

I believe this differs from Q51539860 I looked at above in #55 (comment) as that was also subclass of mirrorless interchangeable-lens camera (Q209918)

TLDR, the modelling on Wikidata or commons needs to change.
The current statement on https://commons.wikimedia.org/wiki/File:Samsung_NX2000_(White)_side.jpg does not say that the image depicts a camera, rather a model of camera, and a model of camera doesnt claim to be instance of camera.

Looking at the modeling of a 5D https://www.wikidata.org/wiki/Q64955
image

So the model should have a subclass of statement
So I went ahead and added it https://www.wikidata.org/w/index.php?title=Q18354117&diff=1653383331&oldid=1620502022

It shouldnt appear in questions anymore, as:

@addshore addshore closed this as completed Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature-depicts
Projects
None yet
Development

No branches or pull requests

3 participants