This repository has been archived by the owner on Jul 7, 2020. It is now read-only.
Remove node cache from DataTree to improve performance #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…true. When true the ConcurrentTree's behavior is the same as before this commit. Nodes are cached up to the max cache size and then they are evicted to the backing page store. When the parameter is false the node cache is bypassed and puts/gets go directly to the IPageDB backing store.
…t cache layer decreases performance.
…ly used by the cache eviction mediator
|
closing this for now. @mspiegel pointed out a potential concurrency issue. all tests are passing but we believe an edge case failure is possible |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing indicates that map jobs run faster without the cache. This version of code passes all unit tests but has not been through a complete hercules build. Hoping to merge this into master and then get the automated analysis from that.