Conform to MediaWiki coding standards #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces phpcs as a Composer script and as part of the Travis tests, and fixes the machine-fixable standards transgressions. Refs https://phabricator.wikimedia.org/T145482
|
I've fixed the remaining CS probs. |
samwilson
changed the title
| @@ -22,5 +27,12 @@ | |||
| "branch-alias": { | |||
| "dev-master": "0.7.x-dev" | |||
| } | |||
| }, | |||
| "scripts": { | |||
| "csfix": "phpcbf --standard=phpcs.xml", | |||
There was a problem hiding this comment.
Please use the standard names (https://github.com/wikimedia/mediawiki-tools-codesniffer#how-to-install). Notably, --standard= should not be necessary.
|
What's the minimum PHP version that addwiki requires? Is it at least 5.5? |
|
Yes, the guzzle version used requires 5.5+ |
|
Thanks @legoktm good points, I've fixed it up. |
addwiki-ci
pushed a commit
that referenced
this pull request
Feb 16, 2021
* require-dev: "php-parallel-lint/php-parallel-lint": "^1.2" Fixes #32 * Fix run-template.php for new parallel-lint * "php-parallel-lint/php-parallel-lint": "^1.2" Again * flush before proc_get_status in run-template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces phpcs as a Composer script and as part of
the Travis tests, and fixes the machine-fixable standards
transgressions.
Refs https://phabricator.wikimedia.org/T145482