-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conform to MediaWiki coding standards #33
Conversation
This change introduces phpcs as a Composer script and as part of the Travis tests, and fixes the machine-fixable standards transgressions. Refs https://phabricator.wikimedia.org/T145482
I've fixed the remaining CS probs. |
@@ -22,5 +27,12 @@ | |||
"branch-alias": { | |||
"dev-master": "0.7.x-dev" | |||
} | |||
}, | |||
"scripts": { | |||
"csfix": "phpcbf --standard=phpcs.xml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the standard names (https://github.com/wikimedia/mediawiki-tools-codesniffer#how-to-install). Notably, --standard= should not be necessary.
What's the minimum PHP version that addwiki requires? Is it at least 5.5? |
Yes, the guzzle version used requires 5.5+ |
Thanks @legoktm good points, I've fixed it up. |
* require-dev: "php-parallel-lint/php-parallel-lint": "^1.2" Fixes #32 * Fix run-template.php for new parallel-lint * "php-parallel-lint/php-parallel-lint": "^1.2" Again * flush before proc_get_status in run-template
This change introduces phpcs as a Composer script and as part of
the Travis tests, and fixes the machine-fixable standards
transgressions.
Refs https://phabricator.wikimedia.org/T145482