Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for LogListGetter #53

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Add documentation for LogListGetter #53

merged 1 commit into from
Apr 1, 2019

Conversation

brendajerop
Copy link
Contributor

@brendajerop brendajerop commented Mar 29, 2019 •
edited
Loading

Changes made:

  • Add Instructions on how to use LogListGetter
  • Add log_list_getter.rst and user_getter.rst to the ToC in index.rst.

samwilson
samwilson requested changes Apr 1, 2019
View reviewed changes
Copy link
Member

@samwilson samwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

One syntax issue, and you should also add this new doc to the ToC in index.rst.

docs/log_list_getter.rst Outdated
@@ -0,0 +1,40 @@
Log List Getter
==================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lines under headings need to be the same length as the headings (here and the two below).

@brendajerop
Copy link
Contributor Author

brendajerop commented Apr 1, 2019 •
edited
Loading

@samwilson Thanks for the review! I've made the changes as requested.

@samwilson samwilson merged commit 97b5b5e into addwiki:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwilson samwilson samwilson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brendajerop @samwilson