This repository has been archived by the owner on Jul 12, 2020. It is now read-only.
add docker support #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👎 While Docker is nice, it doesn't make sense for every Node CLI out there to be dockerized. The few wanting to use this with Docker probably already know how to. |
|
@sindresorhus yep that makes sense |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support in the documentation for how to run
a11yin a docker container. I have also added aDockerfile, so that you can set up Automated Docker builds, for the repository.For it to create a docker build of the server, on every git push, you would need to set up an account on the docker registry and add this repo to build
addyosmani/a11yr.It should pull from the master branch.
How does that sound?