This repository has been archived by the owner on Jul 12, 2020. It is now read-only.
Polyfill bind before running audits #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes addyosmani#44 Signed-off-by: Geoff Pleiss <gpleiss@pivotal.io>
ctaymor
force-pushed
the
phantomjs-polyfill
branch
from
db522bf
to
3cfa37f
Compare
|
Changes LGTM and everything is green. Thanks @ctaymor. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issues in #44
We found that polyfilling
bindmade the audit work on all pages with React components. This PR includes the polyfill before opening the to-be-audited page.