Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not take redirects into account when looking for relative CSS #565

Closed
khaxan opened this issue Sep 10, 2023 · 2 comments
Closed

Does not take redirects into account when looking for relative CSS #565

khaxan opened this issue Sep 10, 2023 · 2 comments

Comments

@khaxan
Copy link

khaxan commented Sep 10, 2023

If I try to get the critical CSS for the website https://cbslocal.com/ I get the following error:

Error: File not found: /fly/bundles/cbsnewscontent/css/door.min.css?v=181d27d1e918a6408b48ea2e220df310
       Current working directory: /critical-css
       Searched in: https://cbslocal.com, https://cbslocal.com/, /critical-css

And the reason is that the domain name redirects to https://www.cbsnews.com/cbslocal/

The CSS file is alive and well at https://www.cbsnews.com/cbslocal/fly/bundles/cbsnewscontent/css/door.min.css?v=181d27d1e918a6408b48ea2e220df310

But this package is looking in the wrong place.

@bezoerb
Copy link
Collaborator

bezoerb commented Oct 6, 2023

@khaxan: would you please check v6.0.1 :)

@bezoerb
Copy link
Collaborator

bezoerb commented Jan 27, 2024

closing this as it should be resolved. Feel free to re-open if there are related issues

@bezoerb bezoerb closed this as completed Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants