New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not take the <base HTML tag into account when looking for relative CSS #566
Labels
Comments
@khaxan: good catch |
bezoerb
added a commit
that referenced
this issue
Sep 14, 2023
bezoerb
added a commit
that referenced
this issue
Sep 14, 2023
bezoerb
added a commit
that referenced
this issue
Sep 14, 2023
* adds support for html base tag (#566) * cleanup
Seems to work ;) |
Still not working 😕
…On Thu, Oct 5, 2023, 14:55 Ben Zörb ***@***.***> wrote:
Closed #566 <#566> as
completed.
—
Reply to this email directly, view it on GitHub
<#566 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCUCXJL7RXGJJ6PHF4IYNHDX54UEBAVCNFSM6AAAAAA4SKBXOGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQGU3DQOJQHAYTOMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I'm sorry, I don't know how I was tagged into this email. I'm having issues
with a different platform, and it's been pure frustrating because now they
stopped replying to me.
On Thu, Oct 5, 2023, 20:53 Second Chance Zone ***@***.***>
wrote:
… Still not working 😕
On Thu, Oct 5, 2023, 14:55 Ben Zörb ***@***.***> wrote:
> Closed #566 <#566> as
> completed.
>
> —
> Reply to this email directly, view it on GitHub
> <#566 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BCUCXJL7RXGJJ6PHF4IYNHDX54UEBAVCNFSM6AAAAAA4SKBXOGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQGU3DQOJQHAYTOMY>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
|
Already working on it 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If I try to find the critical CSS for https://www.ikea.com/ I get the following error:
The correct URL where it should be looking is https://www.ikea.com/global/en/styles-b3b8d77f-5e9k8p.css because there is a <base tag in the markup that points to https://www.ikea.com/global/en/ so all CSS should use that as the base.
The text was updated successfully, but these errors were encountered: