Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not take the <base HTML tag into account when looking for relative CSS #566

Closed
khaxan opened this issue Sep 10, 2023 · 7 comments
Closed

Comments

@khaxan
Copy link

khaxan commented Sep 10, 2023

If I try to find the critical CSS for https://www.ikea.com/ I get the following error:

Error: File not found: styles-b3b8d77f-5e9k8p.css
       Current working directory: /
       Searched in: https://ikea.com, https://ikea.com/, /

The correct URL where it should be looking is https://www.ikea.com/global/en/styles-b3b8d77f-5e9k8p.css because there is a <base tag in the markup that points to https://www.ikea.com/global/en/ so all CSS should use that as the base.

@bezoerb
Copy link
Collaborator

bezoerb commented Sep 12, 2023

@khaxan: good catch

@bezoerb bezoerb self-assigned this Sep 12, 2023
bezoerb added a commit that referenced this issue Sep 14, 2023
bezoerb added a commit that referenced this issue Sep 14, 2023
bezoerb added a commit that referenced this issue Sep 14, 2023
* adds support for html base tag (#566)

* cleanup
@bezoerb
Copy link
Collaborator

bezoerb commented Sep 14, 2023

@khaxan: could you please try again with v5.2.0?

@bezoerb
Copy link
Collaborator

bezoerb commented Oct 5, 2023

Seems to work ;)
Feel free to reopen you you still have issues

@bezoerb bezoerb closed this as completed Oct 5, 2023
@ghost
Copy link

ghost commented Oct 6, 2023 via email

@ghost
Copy link

ghost commented Oct 6, 2023 via email

@khaxan
Copy link
Author

khaxan commented Oct 6, 2023

Hey @bezoerb, thanks for acting on it so quickly. I haven't had a chance to recheck but will try to do it soon.

Any chance #565 could get the same love, it is also quite prevalent

@bezoerb
Copy link
Collaborator

bezoerb commented Oct 6, 2023

Already working on it 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants