-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cssrelpreload #129
Cssrelpreload #129
Conversation
@addyosmani ping ;) |
@@ -142,7 +142,7 @@ function run(data) { | |||
if (err) { | |||
error(err); | |||
} else { | |||
process.stdout.write(val); | |||
process.stdout.write(val, process.exit); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this change was meant to be included in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure there was some reason i put it there even if i can't get it right now as this doesn't have anything todo with the PRs main purpose. Do you have any insights on this being a bad practice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing in particular. I just don't like the fact that this change is
unrelated to the rest. You could make a new PR for this and keep things
clean.
On Jun 11, 2016 23:49, "Ben Zörb" notifications@github.com wrote:
In cli.js
#129 (comment):@@ -142,7 +142,7 @@ function run(data) {
if (err) {
error(err);
} else {
process.stdout.write(val);
process.stdout.write(val, process.exit);
I'm sure there was some reason i put it there even if i can't get it right
now as this doesn't have anything todo with the PRs main purpose. Do you
have any insights on this being a bad practice?—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/addyosmani/critical/pull/129/files/1d124336fb5352b7c6734f669bb4f713b0a29f66#r66711590,
or mute the thread
https://github.com/notifications/unsubscribe/AAVVtYNsNnoz5U2xeSvk7hUqQxOh-tvdks5qKx9lgaJpZM4IJ0Vx
.
Maybe a rebase and squash and should be ready :) |
Actually on second thought, I didn't realize we're expecting the loadCSS to be added to the page with the |
@addyosmani: irrelevant to this but please check the grunt-uncss notifications too :) |
@XhmikosR will do :) |
Thanks @addyosmani and never mind the missing pings ;) |
Bump
inline-critical
to use loadcss recommended-usage-pattern<link rel="preload">
@addyosmani what do you think? Do we want this in?