Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: use 2 spaces indentation #2

Merged
merged 1 commit into from Dec 30, 2014
Merged

Tests: use 2 spaces indentation #2

merged 1 commit into from Dec 30, 2014

Conversation

arthurvr
Copy link
Contributor

Fixes #1. To avoid inconsistencies in the future, added an .editorconfig too.

To avoid inconsistencies in the future, an `.editorconfig` file is
added.
@arthurvr arthurvr mentioned this pull request Dec 30, 2014
addyosmani added a commit that referenced this pull request Dec 30, 2014
Tests: use 2 spaces indentation
@addyosmani addyosmani merged commit 6abd4d6 into addyosmani:master Dec 30, 2014
@addyosmani
Copy link
Owner

Thanks @arthurvr :)

@arthurvr
Copy link
Contributor Author

@addyosmani Same thing over in some other of your repos, such as regex-theme-color. I'll open other PRs tomorrow. Nevermind me asking, but did you used some specific generator or boilerplate for this repos? It something that should be addressed in there too.

@addyosmani
Copy link
Owner

I've recently been using https://github.com/yeoman/generator-node to dogfood our work there and it appears that we could definitely improve some of the editorconfig defaults in https://github.com/yeoman/generator-node/tree/master/app/templates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indentation issue
2 participants